Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetConfiguration failure #1543

Closed
wants to merge 7 commits into from
Closed

Fix GetConfiguration failure #1543

wants to merge 7 commits into from

Conversation

Qiao-Jin
Copy link
Contributor

@Qiao-Jin Qiao-Jin commented Apr 7, 2020

Close #1531

@Qiao-Jin
Copy link
Contributor Author

Qiao-Jin commented Apr 7, 2020

Fix failure when config file modified by editors like VS code, etc. This is due to file read lock not released by editor while changing files.

@nicolegys
Copy link
Contributor

Thank you @Qiao-Jin , now the modified file can be added successfully.

@shargon
Copy link
Member

shargon commented Apr 7, 2020

@nicolegys could you test it again, please?

@nicolegys
Copy link
Contributor

@nicolegys could you test it again, please?

Yes, it works well.

@nicolegys
Copy link
Contributor

#1531 (comment)
@Qiao-Jin @shargon
What do you think?

@Qiao-Jin Qiao-Jin closed this Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to add json file when calling GetConfiguration()
3 participants
@Qiao-Jin @nicolegys @shargon